-
Notifications
You must be signed in to change notification settings - Fork 3.2k
improvement(webhooks): lifecycle management with external providers, remove save configuration #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant "Deploy API" as Deploy
participant "Webhook Deploy" as WH
participant "Provider Subscriptions" as PS
participant "Webhook Utils" as WU
participant Database as DB
participant "External Provider" as EP
User->>Deploy: "POST /api/workflows/{id}/deploy"
Deploy->>WH: "saveTriggerWebhooksForDeploy"
WH->>DB: "Query existing webhooks"
WH->>WH: "Determine webhooks to delete/create"
alt Webhooks to delete
WH->>PS: "cleanupExternalWebhook"
PS->>EP: "Delete webhook subscription"
WH->>DB: "Delete webhook records"
end
alt Credential Set webhooks
WH->>WU: "syncWebhooksForCredentialSet"
WU->>DB: "Create multiple webhooks"
WU->>PS: "createExternalWebhookSubscription"
PS->>EP: "Create external subscription"
end
alt Regular webhooks
WH->>PS: "createExternalWebhookSubscription"
PS->>EP: "Create external subscription"
PS-->>WH: "Updated config with external ID"
WH->>DB: "Insert webhook record"
end
alt Polling webhooks
WH->>WU: "configureGmailPolling/configureOutlookPolling"
WU->>EP: "Configure polling service"
end
WH-->>Deploy: "Success/Error result"
Deploy-->>User: "Deployment response"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17 files reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17 files reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, 1 comment
Summary
Will do webhook lifecycle management as part of deploy process.
Type of Change
Testing
Tested manually
Checklist