Arm backend: Bug fix decompose-var pass. #16559
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the decompose_var_pass assumed that "correction" was an integer argument for the aten.var.dim case, but it is boolean. This meant that 1) get_node_arg() for keepdim actually picked the correction value 2) correction always picked the default value. Since the error was introduced in transform_for_annotation, it was not detected by tests. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I6cd653a69469149a3012d5a4ad77c3808a05d012
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16559
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d77b16c with merge base 9ba1b5d ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the decompose_var_pass assumed that
"correction" was an integer argument for the
aten.var.dim case, but it is boolean. This meant that 1) get_node_arg() for keepdim actually picked the correction value 2) correction always picked the default value.
Since the error was introduced in transform_for_annotation, it was not detected by tests.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai