gh-119180: Document the format parameter in typing.get_type_hints()
#143758
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Viicos
commented
Jan 12, 2026
| is done by traversing :attr:`C.__mro__ <type.__mro__>` and iteratively | ||
| combining | ||
| ``__annotations__`` dictionaries. Annotations on classes appearing | ||
| :term:`annotations <variable annotation>` of each base class. Annotations on classes appearing |
Contributor
Author
There was a problem hiding this comment.
Viicos
changed the title
format parameter in typing.get_type_hints()
Do not mention `__annotations__` dictionaries, as this is slightly outdated since 3.14. Rewrite the note about possible exceptions for clarity. Also do not mention imported type aliases, as since 3.12 aliases with the `type` statement do not suffer from this limitation anymore.
Viicos
force-pushed
the
document-get-type-hints-format
branch
from
f0779d2 to
9dd2b19
Compare
Member
Yes, would you mind changing that line to reference annotationlib.get_annotations instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if we should also update this section:
cpython/Doc/library/typing.rst
Lines 3336 to 3337 in 66e1399
This gives some sense that accessing
__annotations__is safe, which is no longer the case.📚 Documentation preview 📚: https://cpython-previews--143758.org.readthedocs.build/