Fix tag extraction and organization #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IFD prefix to all EXIF tags for clarity (IFD0:, IFD1:, ExifIFD:, GPS:) This clearly differentiates tags from different IFDs (e.g., IFD0:XResolution vs IFD1:XResolution for image vs thumbnail resolution) - Fix IPTC repeatable field handling - aggregate into arrays at parse time Keywords and other repeatable IPTC fields are now properly collected into arrays during extraction rather than creating separate indexed tags - Update tests to reflect new tag naming conventions - Document future human-readable value conversions in ROADMAP (APEX values, enum descriptions, GPS coordinates, etc.) All tests pass. This improves clarity and correctness of metadata extraction. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves tag extraction clarity and fixes IPTC repeatable field handling.
Changes
1. EXIF Tag IFD Prefixing
IFD0:,IFD1:,ExifIFD:,GPS:IFD0:XResolution(image resolution) vsIFD1:XResolution(thumbnail resolution)2. IPTC Repeatable Field Aggregation
Keywords[0],Keywords[1]Keywords: ["Ascot", "Ascot Woods", ...]3. Test Updates
4. Documentation
Validation
testdata/goldens/jpeg/canon_xmp.jpgTest Coverage
🤖 Generated with Claude Code