-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Improve clarity of environment variables description #6602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dvdksn Fixing the issues mentioned in docker/docs#23620 as requested. |
Changed the environment variables section description from: "The following list of environment variables are supported by the `docker` command line:" To: "The following environment variables control the behavior of the `docker` command-line client:" This makes it clearer that these variables control Docker's behavior, and uses the more precise term "command-line client" instead of "command line". This change aligns with docker/cli#6602. Signed-off-by: Andrew Hopp <[email protected]>
|
@thaJeztah could you ✅ this one? |
Changed the environment variables section description from: "The following list of environment variables are supported by the `docker` command line:" To: "The following environment variables control the behavior of the `docker` command-line client:" This makes it clearer that these variables control Docker's behavior, and uses the more precise term "command-line client" instead of "command line". Signed-off-by: Andrew Hopp <[email protected]>
140d36b to
391acef
Compare
|
did a quick rebase, because GitHub actions didn't want to trigger for some reason |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Improved the clarity of the environment variables section description.
Changes
Changed the environment variables section description from:
To:
This change:
Related Issue
docker/docs#23620
Signed-off-by: Andrew Hopp [email protected]