Skip to content

Conversation

@ahopp
Copy link
Contributor

@ahopp ahopp commented Oct 31, 2025

Summary

Improved the clarity of the environment variables section description.

Changes

Changed the environment variables section description from:

The following list of environment variables are supported by the docker command line:

To:

The following environment variables control the behavior of the docker command-line client:

This change:

  • Makes it clearer that these variables control Docker's behavior, not just that they are "supported"
  • Uses the more precise term "command-line client" instead of "command line"
  • Fixes the grammatical issue with "The following list...are supported" (subject-verb agreement)

Related Issue

docker/docs#23620

Signed-off-by: Andrew Hopp [email protected]

@ahopp ahopp requested review from a team and thaJeztah as code owners October 31, 2025 21:19
@ahopp
Copy link
Contributor Author

ahopp commented Oct 31, 2025

@dvdksn Fixing the issues mentioned in docker/docs#23620 as requested.

ahopp added a commit to ahopp/docs that referenced this pull request Oct 31, 2025
Changed the environment variables section description from:
"The following list of environment variables are supported by the `docker` command line:"

To:
"The following environment variables control the behavior of the `docker` command-line client:"

This makes it clearer that these variables control Docker's behavior, and uses the more precise term "command-line client" instead of "command line".

This change aligns with docker/cli#6602.

Signed-off-by: Andrew Hopp <[email protected]>
@dvdksn
Copy link
Contributor

dvdksn commented Jan 12, 2026

@thaJeztah could you ✅ this one?

Changed the environment variables section description from:
"The following list of environment variables are supported by the `docker` command line:"

To:
"The following environment variables control the behavior of the `docker` command-line client:"

This makes it clearer that these variables control Docker's behavior, and uses the more precise term "command-line client" instead of "command line".

Signed-off-by: Andrew Hopp <[email protected]>
@thaJeztah thaJeztah force-pushed the improve-env-vars-description branch from 140d36b to 391acef Compare January 12, 2026 10:20
@thaJeztah
Copy link
Member

did a quick rebase, because GitHub actions didn't want to trigger for some reason

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit bea5850 into docker:master Jan 12, 2026
112 of 113 checks passed
@dvdksn dvdksn mentioned this pull request Jan 12, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants