Skip to content

Conversation

@pyavitz
Copy link
Collaborator

@pyavitz pyavitz commented Jan 13, 2026

general-input-touchscreen-Add-D-WAV-Multitouch.patch (not enabled)
general-memory-marked-nomap.patch (not required)

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced D-WAV USB MultiTouch driver with full multi-touch support for ODROID VU5, VU7, and VU7PLUS devices (kernel 6.19).
  • Reverts

    • Removed D-WAV USB MultiTouch driver from kernel 6.12 and 6.18 releases.
  • Refactor

    • Updated memory reservation handling for nomap regions across kernel versions.

✏️ Tip: You can customize this high-level summary in your review settings.

general-input-touchscreen-Add-D-WAV-Multitouch.patch (not enabled)
general-memory-marked-nomap.patch (not required)

Signed-off-by: Patrick Yavitz <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

The PR removes kernel patch files from the Armbian build system's patch archives for kernel versions 6.12, 6.18, and 6.19. Removed patches include D-WAV USB MultiTouch driver integration for touchscreen devices and memory nomap handling modifications related to reserved memory overlap checks.

Changes

Cohort / File(s) Summary
D-WAV USB MultiTouch driver patches
patch/kernel/archive/meson64-6.12/general-input-touchscreen-Add-D-WAV-Multitouch.patch, patch/kernel/archive/meson64-6.18/general-input-touchscreen-Add-D-WAV-Multitouch.patch, patch/kernel/archive/meson64-6.19/general-input-touchscreen-Add-D-WAV-Multitouch.patch
Removes patches that integrated D-WAV USB MultiTouch driver support, including HID device ID definitions, HID quirks entries, touchscreen Kconfig options, Makefile build rules, and the complete driver implementation (dwav-usb-mt.c). Total: 1,905 lines removed (635 lines per patch)
Memory nomap handling patches
patch/kernel/archive/meson64-6.12/general-memory-marked-nomap.patch, patch/kernel/archive/meson64-6.18/general-memory-marked-nomap.patch, patch/kernel/archive/meson64-6.19/general-memory-marked-nomap.patch
Removes patches that modified drivers/of/of_reserved_mem.c to alter nomap reserved memory handling, including overlap checks and conditional memblock marking logic. Total: 114 lines removed (38 lines per patch)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • rpardini
  • igorpecovnik
  • teknoid
  • Tonymac32
  • SteeManMI
  • NicoD-SBC
  • adeepn

Poem

🐰 Six patches bundled up so tight,
Off to the archive—out of sight!
DWAV's touch and nomap's care,
Gracefully removed with utmost care. ✨
Cleaner patches, lighter load,
Armbian hops down a smoother road!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: deleting patch files that are not required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 25f6eec and 5f0eaf6.

📒 Files selected for processing (6)
  • patch/kernel/archive/meson64-6.12/general-input-touchscreen-Add-D-WAV-Multitouch.patch
  • patch/kernel/archive/meson64-6.12/general-memory-marked-nomap.patch
  • patch/kernel/archive/meson64-6.18/general-input-touchscreen-Add-D-WAV-Multitouch.patch
  • patch/kernel/archive/meson64-6.18/general-memory-marked-nomap.patch
  • patch/kernel/archive/meson64-6.19/general-input-touchscreen-Add-D-WAV-Multitouch.patch
  • patch/kernel/archive/meson64-6.19/general-memory-marked-nomap.patch
💤 Files with no reviewable changes (6)
  • patch/kernel/archive/meson64-6.19/general-memory-marked-nomap.patch
  • patch/kernel/archive/meson64-6.12/general-input-touchscreen-Add-D-WAV-Multitouch.patch
  • patch/kernel/archive/meson64-6.19/general-input-touchscreen-Add-D-WAV-Multitouch.patch
  • patch/kernel/archive/meson64-6.12/general-memory-marked-nomap.patch
  • patch/kernel/archive/meson64-6.18/general-memory-marked-nomap.patch
  • patch/kernel/archive/meson64-6.18/general-input-touchscreen-Add-D-WAV-Multitouch.patch

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • AML-003: Request failed with status code 404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/large PR with 250 lines or more 02 Milestone: First quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 13, 2026
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 13, 2026
@pyavitz pyavitz merged commit 3e40fe9 into armbian:main Jan 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

2 participants