Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 7, 2026

Rationale for this change

Tests test_binary_column_name and test_roundtrip_with_bytes_unicode were being skipped on pandas 2.0+ due to a pandas regression (pandas-dev/pandas#50127) that caused NotImplementedError: |S3 when roundtripping DataFrames with bytes column names.

This issue was already fixed in commit e2ac52d (GH-44171) by changing an if statement to elif in _reconstruct_columns_from_metadata(). The fix prevents bytes-typed columns from falling through to the level.astype(dtype) call that triggered the pandas error.

What changes are included in this PR?

Remove the skip conditions from two test cases.

Are these changes tested?

Yes all related tests pass.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

⚠️ GitHub issue #48759 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd @jorisvandenbossche any thoughts on this?

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 7, 2026
@WillAyd
Copy link
Contributor

WillAyd commented Jan 7, 2026

I am fine with it. Looks like a pretty old issue - I don't think its worth having to move the upper version bound here until this gets fixed

@HyukjinKwon
Copy link
Member Author

Could this be merged by any change? 🙇

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused, shouldn't we have seen this failing on the pandas-devel and pandas upstream job as those are 3.0.0 dev already? This specific test doesn't fail for those, I am wondering whether this could have been solved as part of a different issue.

@HyukjinKwon
Copy link
Member Author

Actually let me check.

@HyukjinKwon HyukjinKwon marked this pull request as draft January 12, 2026 23:30
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 12, 2026
@HyukjinKwon
Copy link
Member Author

huh? tests passed but pandas-dev/pandas#50127 is still not resolved

@HyukjinKwon
Copy link
Member Author

Alright. e2ac52d accidentally fixed this issue together. It does not trigger level.astype(dtype) anymore which would fail per pandas-dev/pandas#50127.

@HyukjinKwon HyukjinKwon marked this pull request as ready for review January 13, 2026 00:44
@HyukjinKwon HyukjinKwon changed the title GH-48759: [Python] Remove Python 3.0.0 comparison for pandas/issues/50127 GH-48759: [Python] Remove Python 3.0.0 condition for pandas/issues/50127 Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants