Skip to content

Conversation

@tuanalumi
Copy link
Contributor

@tuanalumi tuanalumi commented Nov 25, 2024

This PR applies the same calculation from React to Vue example, which would fix:

  • Lagging issue when scrolling
  • Wrong row height

Copy link
Contributor

@kouts kouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @tuanalumi

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2024

View your CI Pipeline Execution ↗ for commit 2a4f0ae.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 8s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 00:53:36 UTC

@tuanalumi tuanalumi requested a review from piecyk January 9, 2025 10:10
@lachlancollins lachlancollins changed the title fix: vue table example examples(vue): fix table example Mar 8, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 8, 2025

Open in Stackblitz

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@887

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@887

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@887

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@887

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@887

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@887

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@887

commit: 2a4f0ae

@lachlancollins lachlancollins merged commit 721bf53 into TanStack:main Mar 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants