Skip to content

feat: improve profiler performance #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edusperoni wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: improve profiler performance #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d8152b
chore: format inspector server
edusperoni Nov 29, 2025
c50e29d
chore: format inspector client
edusperoni Nov 29, 2025
badd175
perf: use const strings in inspector messages
edusperoni Jan 13, 2026
e848a01
perf: generate buffer chunks in C++ memory without using JS
edusperoni Jan 13, 2026
18f69c1
feat: add json parsing and better handling of categories
edusperoni Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ NativeScript/inspector/third_party/*
NativeScript/inspector/third_party/*/*
NativeScript/inspector/third_party/*/*/*
NativeScript/inspector/third_party/*/*/*/*
NativeScript/third_party/*
20 changes: 13 additions & 7 deletions NativeScript/inspector/InspectorServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
#ifndef InspectorServer_h
#define InspectorServer_h

#include <dispatch/dispatch.h>
#include <sys/types.h>

#include <functional>
#include <string>
#include <sys/types.h>
#include <dispatch/dispatch.h>

namespace v8_inspector {

class InspectorServer {
public:
static in_port_t Init(std::function<void (std::function<void (std::string)>)> onClientConnected, std::function<void (std::string)> onMessage);
private:
static void Send(dispatch_io_t channel, dispatch_queue_t queue, std::string message);
public:
static in_port_t Init(
std::function<void(std::function<void(const std::string&)>)>
onClientConnected,
std::function<void(const std::string&)> onMessage);

private:
static void Send(dispatch_io_t channel, dispatch_queue_t queue,
const std::string& message);
};

}
} // namespace v8_inspector

#endif /* InspectorServer_h */
240 changes: 122 additions & 118 deletions NativeScript/inspector/InspectorServer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,143 +5,147 @@

namespace v8_inspector {

in_port_t InspectorServer::Init(std::function<void (std::function<void (std::string)>)> onClientConnected, std::function<void (std::string)> onMessage) {
in_port_t listenPort = 18183;
in_port_t InspectorServer::Init(
std::function<void(std::function<void(const std::string&)>)> onClientConnected,
std::function<void(const std::string&)> onMessage) {
in_port_t listenPort = 18183;

int serverSocket = -1;
if ((serverSocket = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0) {
assert(false);
}

struct sockaddr_in serverAddress;
memset(&serverAddress, 0, sizeof(serverAddress));
serverAddress.sin_family = AF_INET;
serverAddress.sin_addr.s_addr = htonl(INADDR_ANY);
do {
serverAddress.sin_port = htons(listenPort);
} while (bind(serverSocket, (struct sockaddr*)&serverAddress, sizeof(serverAddress)) < 0 &&
++listenPort);

// Make the socket non-blocking
if (fcntl(serverSocket, F_SETFL, O_NONBLOCK) < 0) {
shutdown(serverSocket, SHUT_RDWR);
close(serverSocket);
assert(false);
}

// Set up the dispatch source that will alert us to new incoming connections
dispatch_queue_t q = dispatch_queue_create("server_queue", DISPATCH_QUEUE_CONCURRENT);
dispatch_source_t acceptSource =
dispatch_source_create(DISPATCH_SOURCE_TYPE_READ, serverSocket, 0, q);
dispatch_source_set_event_handler(acceptSource, ^{
const unsigned long numPendingConnections = dispatch_source_get_data(acceptSource);
for (unsigned long i = 0; i < numPendingConnections; i++) {
int clientSocket = -1;
struct sockaddr_in echoClntAddr;
unsigned int clntLen = sizeof(echoClntAddr);

// Wait for a client to connect
if ((clientSocket = accept(serverSocket, (struct sockaddr*)&echoClntAddr, &clntLen)) >= 0) {
dispatch_io_t channel =
dispatch_io_create(DISPATCH_IO_STREAM, clientSocket, q, ^(int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}
close(clientSocket);
});

onClientConnected([channel, q](std::string message) { Send(channel, q, message); });

__block dispatch_io_handler_t receiver = ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}

int serverSocket = -1;
if ((serverSocket = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0) {
assert(false);
}
const void* bytes = [(NSData*)data bytes];
if (!bytes) {
return;
}

struct sockaddr_in serverAddress;
memset(&serverAddress, 0, sizeof(serverAddress));
serverAddress.sin_family = AF_INET;
serverAddress.sin_addr.s_addr = htonl(INADDR_ANY);
do {
serverAddress.sin_port = htons(listenPort);
} while (bind(serverSocket, (struct sockaddr *) &serverAddress, sizeof(serverAddress)) < 0 && ++listenPort);

// Make the socket non-blocking
if (fcntl(serverSocket, F_SETFL, O_NONBLOCK) < 0) {
shutdown(serverSocket, SHUT_RDWR);
close(serverSocket);
assert(false);
}
uint32_t length = ntohl(*(uint32_t*)bytes);

// Configure the channel...
dispatch_io_set_low_water(channel, length);

// Set up the dispatch source that will alert us to new incoming connections
dispatch_queue_t q = dispatch_queue_create("server_queue", DISPATCH_QUEUE_CONCURRENT);
dispatch_source_t acceptSource = dispatch_source_create(DISPATCH_SOURCE_TYPE_READ, serverSocket, 0, q);
dispatch_source_set_event_handler(acceptSource, ^{
const unsigned long numPendingConnections = dispatch_source_get_data(acceptSource);
for (unsigned long i = 0; i < numPendingConnections; i++) {
int clientSocket = -1;
struct sockaddr_in echoClntAddr;
unsigned int clntLen = sizeof(echoClntAddr);

// Wait for a client to connect
if ((clientSocket = accept(serverSocket, (struct sockaddr *) &echoClntAddr, &clntLen)) >= 0) {
dispatch_io_t channel = dispatch_io_create(DISPATCH_IO_STREAM, clientSocket, q, ^(int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}
close(clientSocket);
});

onClientConnected([channel, q](std::string message) {
Send(channel, q, message);
});

__block dispatch_io_handler_t receiver = ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}

const void* bytes = [(NSData*)data bytes];
if (!bytes) {
return;
}

uint32_t length = ntohl(*(uint32_t*)bytes);

// Configure the channel...
dispatch_io_set_low_water(channel, length);

// Setup read handler
dispatch_io_read(channel, 0, length, q, ^(bool done, dispatch_data_t data, int error) {
BOOL close = NO;
if (error) {
NSLog(@"Error: %s", strerror(error));
close = YES;
}

const size_t size = data ? dispatch_data_get_size(data) : 0;
if (size) {
NSString* payload = [[NSString alloc] initWithData:(NSData*)data encoding:NSUTF16LittleEndianStringEncoding];

onMessage([payload UTF8String]);
// Setup read handler
dispatch_io_read(channel, 0, length, q, ^(bool done, dispatch_data_t data, int error) {
BOOL close = NO;
if (error) {
NSLog(@"Error: %s", strerror(error));
close = YES;
}

const size_t size = data ? dispatch_data_get_size(data) : 0;
if (size) {
NSString* payload = [[NSString alloc] initWithData:(NSData*)data
encoding:NSUTF16LittleEndianStringEncoding];

onMessage([payload UTF8String]);

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Warc-retain-cycles"
dispatch_io_read(channel, 0, 4, q, receiver);
dispatch_io_read(channel, 0, 4, q, receiver);
#pragma clang diagnostic pop
} else {
close = YES;
}

if (close) {
dispatch_io_close(channel, DISPATCH_IO_STOP);
}
});
};

if (channel) {
dispatch_io_read(channel, 0, 4, q, receiver);
}
} else {
close = YES;
}
else {
NSLog(@"accept() failed;\n");

if (close) {
dispatch_io_close(channel, DISPATCH_IO_STOP);
}
});
};

if (channel) {
dispatch_io_read(channel, 0, 4, q, receiver);
}
});
} else {
NSLog(@"accept() failed;\n");
}
}
});

// Resume the source so we're ready to accept once we listen()
dispatch_resume(acceptSource);
// Resume the source so we're ready to accept once we listen()
dispatch_resume(acceptSource);

// Listen() on the socket
if (listen(serverSocket, SOMAXCONN) < 0) {
shutdown(serverSocket, SHUT_RDWR);
close(serverSocket);
assert(false);
}
// Listen() on the socket
if (listen(serverSocket, SOMAXCONN) < 0) {
shutdown(serverSocket, SHUT_RDWR);
close(serverSocket);
assert(false);
}

return listenPort;
return listenPort;
}

void InspectorServer::Send(dispatch_io_t channel, dispatch_queue_t queue, std::string message) {
NSString* str = [NSString stringWithUTF8String:message.c_str()];
NSUInteger length = [str lengthOfBytesUsingEncoding:NSUTF16LittleEndianStringEncoding];
void InspectorServer::Send(dispatch_io_t channel, dispatch_queue_t queue,
const std::string& message) {
NSString* str = [NSString stringWithUTF8String:message.c_str()];
NSUInteger length = [str lengthOfBytesUsingEncoding:NSUTF16LittleEndianStringEncoding];

uint8_t* buffer = (uint8_t*)malloc(length + sizeof(uint32_t));
uint8_t* buffer = (uint8_t*)malloc(length + sizeof(uint32_t));

*(uint32_t*)buffer = htonl(length);
*(uint32_t*)buffer = htonl(length);

[str getBytes:&buffer[sizeof(uint32_t)]
maxLength:length
usedLength:NULL
encoding:NSUTF16LittleEndianStringEncoding
options:0
range:NSMakeRange(0, str.length)
remainingRange:NULL];
[str getBytes:&buffer[sizeof(uint32_t)]
maxLength:length
usedLength:NULL
encoding:NSUTF16LittleEndianStringEncoding
options:0
range:NSMakeRange(0, str.length)
remainingRange:NULL];

dispatch_data_t data = dispatch_data_create(buffer, length + sizeof(uint32_t), queue, ^{
free(buffer);
});
dispatch_data_t data = dispatch_data_create(buffer, length + sizeof(uint32_t), queue, ^{
free(buffer);
});

dispatch_io_write(channel, 0, data, queue, ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}
});
dispatch_io_write(channel, 0, data, queue, ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
}
});
}

}
} // namespace v8_inspector
Loading
Loading