-
Notifications
You must be signed in to change notification settings - Fork 477
chore: final_status on top of refactor #15996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gnufede/SDTEST-2981-4
Are you sure you want to change the base?
Conversation
some more changes cleanup
Codeowners resolved as |
Performance SLOsComparing candidate gnufede/SDTEST-2981-5 (b98db11) with baseline gnufede/SDTEST-2981-4 (a450eb7) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 104.167µs (SLO: <130.000µs 📉 -19.9%) vs baseline: +3.3% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 100.486µs (SLO: <130.000µs 📉 -22.7%) vs baseline: -0.7% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 28.051µs (SLO: <40.000µs 📉 -29.9%) vs baseline: -0.1% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.3% ✅ add_noaspectTime: ✅ 48.769µs (SLO: <70.000µs 📉 -30.3%) vs baseline: -0.6% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 258.861µs (SLO: <400.000µs 📉 -35.3%) vs baseline: +0.6% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 655.804µs (SLO: <800.000µs 📉 -18.0%) vs baseline: +0.9% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ bytearray_extend_noaspectTime: ✅ 266.623µs (SLO: <400.000µs 📉 -33.3%) vs baseline: +0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 141.748µs (SLO: <300.000µs 📉 -52.8%) vs baseline: +0.8% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 222.699µs (SLO: <300.000µs 📉 -25.8%) vs baseline: +0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 134.243µs (SLO: <200.000µs 📉 -32.9%) vs baseline: +1.0% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.4% ✅ bytesio_aspectTime: ✅ 3.829ms (SLO: <5.000ms 📉 -23.4%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 321.095µs (SLO: <420.000µs 📉 -23.5%) vs baseline: -0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 89.960µs (SLO: <300.000µs 📉 -70.0%) vs baseline: +0.6% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ capitalize_noaspectTime: ✅ 250.856µs (SLO: <300.000µs 📉 -16.4%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 89.639µs (SLO: <500.000µs 📉 -82.1%) vs baseline: -0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 308.116µs (SLO: <500.000µs 📉 -38.4%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 87.381µs (SLO: <100.000µs 📉 -12.6%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 152.221µs (SLO: <210.000µs 📉 -27.5%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 85.093µs (SLO: <200.000µs 📉 -57.5%) vs baseline: -0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 139.437µs (SLO: <200.000µs 📉 -30.3%) vs baseline: +1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 14.726ms (SLO: <19.200ms 📉 -23.3%) vs baseline: +0.1% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 16.469ms (SLO: <21.500ms 📉 -23.4%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 364.529µs (SLO: <500.000µs 📉 -27.1%) vs baseline: -0.9% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 309.510µs (SLO: <500.000µs 📉 -38.1%) vs baseline: +1.3% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.1% ✅ index_aspectTime: ✅ 135.080µs (SLO: <300.000µs 📉 -55.0%) vs baseline: +8.9% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 40.475µs (SLO: <300.000µs 📉 -86.5%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 221.092µs (SLO: <300.000µs 📉 -26.3%) vs baseline: +1.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 148.985µs (SLO: <300.000µs 📉 -50.3%) vs baseline: +1.2% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 572.774µs (SLO: <700.000µs 📉 -18.2%) vs baseline: 📈 +15.3% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.2% ✅ ljust_noaspectTime: ✅ 256.534µs (SLO: <300.000µs 📉 -14.5%) vs baseline: +1.0% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 306.051µs (SLO: <500.000µs 📉 -38.8%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 233.553µs (SLO: <300.000µs 📉 -22.1%) vs baseline: -0.4% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 0.270ms (SLO: <3.000ms 📉 -91.0%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.179ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +0.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 14.367ms (SLO: <18.750ms 📉 -23.4%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.891ms (SLO: <19.350ms 📉 -23.0%) vs baseline: +0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ modulo_aspect_for_bytesTime: ✅ 14.500ms (SLO: <18.900ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.670ms (SLO: <19.150ms 📉 -23.4%) vs baseline: -0.4% Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.359ms (SLO: <3.000ms 📉 -88.0%) vs baseline: +1.1% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 18.456ms (SLO: <24.000ms 📉 -23.1%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <44.000MB -3.0%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 285.846µs (SLO: <300.000µs -4.7%) vs baseline: +0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 319.066µs (SLO: <420.000µs 📉 -24.0%) vs baseline: +0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 46.785µs (SLO: <90.000µs 📉 -48.0%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 379.222µs (SLO: <500.000µs 📉 -24.2%) vs baseline: +0.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 181.770µs (SLO: <300.000µs 📉 -39.4%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 181.308µs (SLO: <300.000µs 📉 -39.6%) vs baseline: -0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 53.831µs (SLO: <90.000µs 📉 -40.2%) vs baseline: +0.3% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 4.442ms (SLO: <5.000ms 📉 -11.2%) vs baseline: 📈 +14.6% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 358.133µs (SLO: <500.000µs 📉 -28.4%) vs baseline: +1.3% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 268.412µs (SLO: <350.000µs 📉 -23.3%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 176.382µs (SLO: <240.000µs 📉 -26.5%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 341.332µs (SLO: <500.000µs 📉 -31.7%) vs baseline: -0.6% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ swapcase_noaspectTime: ✅ 272.900µs (SLO: <400.000µs 📉 -31.8%) vs baseline: +0.7% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 329.741µs (SLO: <500.000µs 📉 -34.1%) vs baseline: -0.9% Memory: ✅ 42.644MB (SLO: <43.000MB 🟡 -0.8%) vs baseline: +5.1% ✅ title_noaspectTime: ✅ 258.501µs (SLO: <400.000µs 📉 -35.4%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 499.096µs (SLO: <700.000µs 📉 -28.7%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 422.748µs (SLO: <500.000µs 📉 -15.5%) vs baseline: -1.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ upper_aspectTime: ✅ 305.573µs (SLO: <500.000µs 📉 -38.9%) vs baseline: -1.0% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 234.761µs (SLO: <400.000µs 📉 -41.3%) vs baseline: +0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 505.453µs (SLO: <700.000µs 📉 -27.8%) vs baseline: 📈 +20.3% Memory: ✅ 42.251MB (SLO: <43.500MB -2.9%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 422.345µs (SLO: <700.000µs 📉 -39.7%) vs baseline: -0.9% Memory: ✅ 42.310MB (SLO: <43.500MB -2.7%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 625.943µs (SLO: <700.000µs 📉 -10.6%) vs baseline: +0.2% Memory: ✅ 42.349MB (SLO: <43.500MB -2.6%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 627.917µs (SLO: <700.000µs 📉 -10.3%) vs baseline: -0.8% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 349.201µs (SLO: <700.000µs 📉 -50.1%) vs baseline: -1.5% Memory: ✅ 42.408MB (SLO: <43.500MB -2.5%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 356.029µs (SLO: <700.000µs 📉 -49.1%) vs baseline: ~same Memory: ✅ 42.251MB (SLO: <43.500MB -2.9%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 484.411µs (SLO: <700.000µs 📉 -30.8%) vs baseline: -0.7% Memory: ✅ 42.330MB (SLO: <43.500MB -2.7%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 496.678µs (SLO: <700.000µs 📉 -29.0%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.6% ✅ ospathsplitdrive_aspectTime: ✅ 370.500µs (SLO: <700.000µs 📉 -47.1%) vs baseline: -0.6% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 73.555µs (SLO: <700.000µs 📉 -89.5%) vs baseline: -0.6% Memory: ✅ 42.271MB (SLO: <43.500MB -2.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 458.982µs (SLO: <700.000µs 📉 -34.4%) vs baseline: ~same Memory: ✅ 42.428MB (SLO: <43.500MB -2.5%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 460.937µs (SLO: <700.000µs 📉 -34.2%) vs baseline: +0.5% Memory: ✅ 42.231MB (SLO: <43.500MB -2.9%) vs baseline: +4.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.373µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +13.4% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 199.703µs (SLO: <220.000µs -9.2%) vs baseline: +0.6% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.309µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.6% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.850µs (SLO: <230.000µs -7.5%) vs baseline: -0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ 1-gauge-metric-1-timesTime: ✅ 2.183µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.2% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.806µs (SLO: <150.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.155µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +0.1% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.227µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.4% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.073ms (SLO: <22.000ms -8.8%) vs baseline: -0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.245ms (SLO: <2.550ms 📉 -12.0%) vs baseline: -0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.409ms (SLO: <1.550ms -9.1%) vs baseline: -0.6% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.179ms (SLO: <2.550ms 📉 -14.6%) vs baseline: +0.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.527µs (SLO: <20.000µs 📉 -77.4%) vs baseline: ~same Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 174.163µs (SLO: <250.000µs 📉 -30.3%) vs baseline: -0.7% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.184ms (SLO: <2.500ms 📉 -12.7%) vs baseline: -0.3% Memory: ✅ 36.137MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes