-
Notifications
You must be signed in to change notification settings - Fork 476
refactor(mcp): replace ddtrace argument with telemetry
#15972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codeowners resolved as |
daaccda to
d2ec894
Compare
ddtrace with telemetryddtrace with telemetry
ddtrace with telemetryddtrace with telemetry
d2ec894 to
1b466c8
Compare
Performance SLOsComparing candidate jb/replace-ddtrace-with-telemetry- (5b827ad) with baseline main (624ef30) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.875µs (SLO: <130.000µs 📉 -20.1%) vs baseline: +3.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 100.948µs (SLO: <130.000µs 📉 -22.3%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 28.141µs (SLO: <40.000µs 📉 -29.6%) vs baseline: -1.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 49.049µs (SLO: <70.000µs 📉 -29.9%) vs baseline: +0.2% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 258.903µs (SLO: <400.000µs 📉 -35.3%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 649.464µs (SLO: <800.000µs 📉 -18.8%) vs baseline: +0.1% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 270.299µs (SLO: <400.000µs 📉 -32.4%) vs baseline: +1.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 141.049µs (SLO: <300.000µs 📉 -53.0%) vs baseline: +0.7% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 221.018µs (SLO: <300.000µs 📉 -26.3%) vs baseline: -1.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 135.098µs (SLO: <200.000µs 📉 -32.5%) vs baseline: +0.3% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 3.820ms (SLO: <5.000ms 📉 -23.6%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 321.867µs (SLO: <420.000µs 📉 -23.4%) vs baseline: +0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 89.996µs (SLO: <300.000µs 📉 -70.0%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 251.833µs (SLO: <300.000µs 📉 -16.1%) vs baseline: +0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 93.568µs (SLO: <500.000µs 📉 -81.3%) vs baseline: +4.9% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 307.792µs (SLO: <500.000µs 📉 -38.4%) vs baseline: +0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 87.189µs (SLO: <100.000µs 📉 -12.8%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.4% ✅ decode_noaspectTime: ✅ 155.173µs (SLO: <210.000µs 📉 -26.1%) vs baseline: +2.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 84.869µs (SLO: <200.000µs 📉 -57.6%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 138.337µs (SLO: <200.000µs 📉 -30.8%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 14.732ms (SLO: <19.200ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 16.478ms (SLO: <21.500ms 📉 -23.4%) vs baseline: ~same Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 364.524µs (SLO: <500.000µs 📉 -27.1%) vs baseline: -1.0% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 305.898µs (SLO: <500.000µs 📉 -38.8%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 123.957µs (SLO: <300.000µs 📉 -58.7%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.779µs (SLO: <300.000µs 📉 -86.4%) vs baseline: +1.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 217.537µs (SLO: <300.000µs 📉 -27.5%) vs baseline: -0.5% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 149.650µs (SLO: <300.000µs 📉 -50.1%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 500.547µs (SLO: <700.000µs 📉 -28.5%) vs baseline: +0.4% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 253.282µs (SLO: <300.000µs 📉 -15.6%) vs baseline: -1.0% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 305.091µs (SLO: <500.000µs 📉 -39.0%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 233.505µs (SLO: <300.000µs 📉 -22.2%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.6% ✅ lstrip_aspectTime: ✅ 0.272ms (SLO: <3.000ms 📉 -90.9%) vs baseline: -0.1% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 0.197ms (SLO: <3.000ms 📉 -93.4%) vs baseline: 📈 +10.8% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 14.549ms (SLO: <18.750ms 📉 -22.4%) vs baseline: +1.3% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.898ms (SLO: <19.350ms 📉 -23.0%) vs baseline: +0.3% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 14.500ms (SLO: <18.900ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.681ms (SLO: <19.150ms 📉 -23.3%) vs baseline: +0.4% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.360ms (SLO: <3.000ms 📉 -88.0%) vs baseline: +0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ replace_aspectTime: ✅ 18.428ms (SLO: <24.000ms 📉 -23.2%) vs baseline: -0.1% Memory: ✅ 42.664MB (SLO: <44.000MB -3.0%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 286.058µs (SLO: <300.000µs -4.6%) vs baseline: +1.0% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 317.524µs (SLO: <420.000µs 📉 -24.4%) vs baseline: -0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 46.777µs (SLO: <90.000µs 📉 -48.0%) vs baseline: -0.3% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 381.813µs (SLO: <500.000µs 📉 -23.6%) vs baseline: +0.7% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 182.051µs (SLO: <300.000µs 📉 -39.3%) vs baseline: +0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 180.857µs (SLO: <300.000µs 📉 -39.7%) vs baseline: -1.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 53.794µs (SLO: <90.000µs 📉 -40.2%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 3.895ms (SLO: <5.000ms 📉 -22.1%) vs baseline: +0.4% Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ stringio_noaspectTime: ✅ 386.313µs (SLO: <500.000µs 📉 -22.7%) vs baseline: +8.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 271.001µs (SLO: <350.000µs 📉 -22.6%) vs baseline: +0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 178.108µs (SLO: <240.000µs 📉 -25.8%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ swapcase_aspectTime: ✅ 342.445µs (SLO: <500.000µs 📉 -31.5%) vs baseline: -0.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 272.539µs (SLO: <400.000µs 📉 -31.9%) vs baseline: +0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 330.633µs (SLO: <500.000µs 📉 -33.9%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.000MB 🟡 -1.0%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 258.935µs (SLO: <400.000µs 📉 -35.3%) vs baseline: -0.4% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 499.738µs (SLO: <700.000µs 📉 -28.6%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 424.639µs (SLO: <500.000µs 📉 -15.1%) vs baseline: -2.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 307.671µs (SLO: <500.000µs 📉 -38.5%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 235.755µs (SLO: <400.000µs 📉 -41.1%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 504.024µs (SLO: <700.000µs 📉 -28.0%) vs baseline: 📈 +20.3% Memory: ✅ 42.290MB (SLO: <43.500MB -2.8%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 429.975µs (SLO: <700.000µs 📉 -38.6%) vs baseline: +0.7% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 623.968µs (SLO: <700.000µs 📉 -10.9%) vs baseline: +0.3% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 629.650µs (SLO: <700.000µs 📉 -10.0%) vs baseline: -0.6% Memory: ✅ 42.290MB (SLO: <43.500MB -2.8%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 348.728µs (SLO: <700.000µs 📉 -50.2%) vs baseline: +0.5% Memory: ✅ 42.271MB (SLO: <43.500MB -2.8%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 358.955µs (SLO: <700.000µs 📉 -48.7%) vs baseline: -0.6% Memory: ✅ 42.448MB (SLO: <43.500MB -2.4%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 481.267µs (SLO: <700.000µs 📉 -31.2%) vs baseline: -1.2% Memory: ✅ 42.290MB (SLO: <43.500MB -2.8%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 495.607µs (SLO: <700.000µs 📉 -29.2%) vs baseline: -1.0% Memory: ✅ 42.271MB (SLO: <43.500MB -2.8%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 371.043µs (SLO: <700.000µs 📉 -47.0%) vs baseline: -0.1% Memory: ✅ 42.231MB (SLO: <43.500MB -2.9%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 72.710µs (SLO: <700.000µs 📉 -89.6%) vs baseline: -0.7% Memory: ✅ 42.428MB (SLO: <43.500MB -2.5%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 461.049µs (SLO: <700.000µs 📉 -34.1%) vs baseline: +0.6% Memory: ✅ 42.310MB (SLO: <43.500MB -2.7%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 463.391µs (SLO: <700.000µs 📉 -33.8%) vs baseline: -0.7% Memory: ✅ 42.290MB (SLO: <43.500MB -2.8%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.432µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +14.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 200.340µs (SLO: <220.000µs -8.9%) vs baseline: -0.6% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.360µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +0.3% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.258µs (SLO: <230.000µs -6.4%) vs baseline: -0.2% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.189µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.3% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.765µs (SLO: <150.000µs -8.8%) vs baseline: -0.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.163µs (SLO: <20.000µs 📉 -84.2%) vs baseline: -0.8% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 215.404µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +0.7% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.083ms (SLO: <22.000ms -8.7%) vs baseline: +1.1% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.206ms (SLO: <2.550ms 📉 -13.5%) vs baseline: -0.6% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.416ms (SLO: <1.550ms -8.7%) vs baseline: +0.8% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.182ms (SLO: <2.550ms 📉 -14.4%) vs baseline: +0.8% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.523µs (SLO: <20.000µs 📉 -77.4%) vs baseline: -1.4% Memory: ✅ 35.252MB (SLO: <35.500MB 🟡 -0.7%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 174.377µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.6% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.199ms (SLO: <2.500ms 📉 -12.1%) vs baseline: +0.8% Memory: ✅ 36.117MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +4.6% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
ddtrace with telemetryddtrace argument with telemetry
sabrenner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be able to get rid of the release note
releasenotes/notes/rename-mcp-intent-capture-argument-57a5b2b261052441.yaml
Outdated
Show resolved
Hide resolved
1b466c8 to
5b827ad
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
mergequeue build completed successfully, but the github api returned an error while merging the pr.
DetailsError: PUT https://api.github.com/repos/DataDog/dd-trace-py/pulls/15972/merge: 405 Pull Request is not mergeable [] (Request ID: A6A6:157E99:1375740:5445721:696565B5) FullStacktrace: |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |

What does this PR do?
Renames the injected MCP tool argument used for intent capture from
ddtracetotelemetry.Motivation
Feedback that it may be confusing to consumers of mcp servers.