dotnet: silence mime type warning, make build (more) deterministic #261
Conversation
…d more deterministic Fixes WebKit#196
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| 86:ut_dotnet_BenchTask__RunBatchd__7_MoveNext | ||
| 87:dotnet_Interop_RunIteration_int_int_int_int | ||
| 88:dotnet_Interop___Wrapper_RunIteration_2022265694_System_Runtime_InteropServices_JavaScript_JSMarshalerArgument_ | ||
| 88:dotnet_Interop___Wrapper_RunIteration_1052663206_System_Runtime_InteropServices_JavaScript_JSMarshalerArgument_ |
There was a problem hiding this comment.
@pavelsavara This is a difference that seems to appear on every rebuild, despite passing -p:Deterministic=true -p:DeterministicSourcePaths=true to dotnet publish
There was a problem hiding this comment.
Great to know, thanks! Since Net10 seems to have been stable/released in November (https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-10/overview), shall we switch/rebuild with the new version? @kmiller68 @eqrion
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Overal LGTM, worth sanity checking if there's a performance difference between the new version and old one before landing though.
@kmiller68: I just briefly compared on jsc, d8, and Chrome on x64 Linux and we are getting the same (modulo noise) times and scores before and after this rebuild. |
|
Are the PR changes in the WebCIL files caused by not running wasm-opt on them ? Or that's also on dotnet side ? |
That is because of @@ -10,18 +10,18 @@
(export "webcilSize" (global $global$1))
(export "getWebcilSize" (func $0))
(export "getWebcilPayload" (func $1))
- (func $0 (type $0) (param $destPtr i32)
+ (func $0 (type $0) (param $0 i32)
(memory.init $0
- (local.get $destPtr)
+ (local.get $0)
(i32.const 0)
(i32.const 4)
)
)
- (func $1 (type $1) (param $d i32) (param $n i32)
+ (func $1 (type $1) (param $0 i32) (param $1 i32)
(memory.init $1
- (local.get $d)
+ (local.get $0)
(i32.const 0)
- (local.get $n)
+ (local.get $1)
)
)
) |
3 participants
-p:Deterministic=true -p:DeterministicSourcePaths=trueto dotnet build command to at least exclude file paths as a source of binary differenceswasm-opton the main Wasm binary, not WebCIL files (CC @pavelsavara)